[5.3] Remove un-used variables#45045
Merged
rdeutz merged 2 commits intojoomla:5.3-devfrom Mar 8, 2025
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on 318ceb5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45045. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 318ceb5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45045. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45045. |
rdeutz
approved these changes
Mar 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
This simple PR remove the un-used variables in several methods across our code base. The rector rule RemoveUnusedVariableAssignRector help detects these variables. There are more un-used variables, but I only remove the most obvious one.
Testing Instructions
Code review. With a modern IDE like PHPStorm, you can easily check and see these variables are not used at all in the method it is defined/assigned value.
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed